fix(popover-container): ensure that tab sequence is not lost when container has radio buttons #7100
+216
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainer has radio buttons This fix ensures that if the last focusable element in a popover container is a radio button, that the tab sequence is not affected once focus is outside of the container fixes #7067
DipperTheDan
added
No UX QA Required
and removed
Pending UX QA
Pending a11y Review
labels
|
Looks like you can't get off the popover at all when using the |
nineteen88
approved these changes
Dec 2, 2024
| @@ -279,7 +279,7 @@ const FocusTrap = ({ | |||
| onFocus: updateCurrentFocusedElement, | |||
| }); | |||
|
|
|||
| // passes focusProps, sets tabIndex and onBlur if no tabIndex has been expicitly set on child | |||
| // passes focusProps, sets tabIndex and onBlur if no tabIndex has been explicitly set on child | |||
There was a problem hiding this comment.
question: since this isn't related to the commit should we separate it out as it's own chore commit?
There was a problem hiding this comment.
Yeah, good idea. I'll do that when I come to rebase with master, prior to merging the work.
damienrobson-sage
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures that if the last focusable element in a popover container is a radio button, that the tab sequence is not affected once focus is outside of the container
fixes #7067
Proposed behaviour
Screen.Recording.2024-11-27.at.15.10.51.mov
Current behaviour
Screen.Recording.2024-11-27.at.15.12.32.mov
Checklist
d.tsfile added or updated if requiredQA
Additional context
N/A
Testing instructions
Steps to reproduce
Using the new
With Radio Buttonexample:with Radio childrenbutton.There should also be no functional regressions or changes to the other
PopoverContainerexamples.